Grafana API improvements #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daisycrego
commented
Mar 29, 2020
•
daisycrego
commented
- Add tests to new GrafanaConfigurations (GFConfig) view which stores and validates Grafana credentials.
- Update Grafana class to better support credential validation - added a method to validate credentials, improved error handling so that callers can try-except for different error cases. Added tests for expected error cases.
…t expected error messages are displayed, confirm that a GFConfig object can be created successfully.
…0-cs-gy-9223-class into grafana Sync up with frontend-team.
…Modify all tests and views that create a Grafana instance so that they first create a GFConfig. Condense code for building API endpoint urls. Fix issue with events test that was leading to Quota reached API failures (some tests were creating dashboards but not cleaning them up).
…: Grafana constructor now takes a GFConfig object directly.
…reduce code reuse across tests.
GFConfig testing; Change Grafana class to take GFConfig in constructor; Fix issue with API tests causing Quota Reached error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.